Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove merit kwarg #72

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Remove merit kwarg #72

merged 2 commits into from
Nov 8, 2022

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Nov 2, 2022

Only one merit function is accepted, so I suggest to add a package issue and remove from the kwargs until done.

Only one merit function is accepted, so I suggest to add a package issue and remove from the kwargs until done.
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 88.60% // Head: 88.60% // No change to project coverage 👍

Coverage data is based on head (af17b4a) compared to base (5ed5464).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #72   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files           2        2           
  Lines         395      395           
=======================================
  Hits          350      350           
  Misses         45       45           
Impacted Files Coverage Δ
src/CaNNOLeS.jl 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigot tmigot merged commit 2038641 into main Nov 8, 2022
@tmigot tmigot deleted the tmigot-patch-1 branch November 8, 2022 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant