Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function signature within its docstring #208

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

amontoison
Copy link
Member

@coveralls
Copy link

coveralls commented Aug 28, 2020

Coverage Status

Coverage remained the same at 97.389% when pulling badf31a on amontoison:docs into cd6b051 on JuliaSmoothOptimizers:master.

@dpo
Copy link
Member

dpo commented Aug 28, 2020

:-(
what about automatically-generated signatures in the docstring? The advantage is that they stay in sync with the actual function signature.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #208 into master will decrease coverage by 0.06%.
The diff coverage is 98.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #208      +/-   ##
==========================================
- Coverage   97.42%   97.36%   -0.07%     
==========================================
  Files          30       29       -1     
  Lines        3229     3193      -36     
==========================================
- Hits         3146     3109      -37     
- Misses         83       84       +1     
Impacted Files Coverage Δ
src/Krylov.jl 100.00% <ø> (ø)
src/bilq.jl 100.00% <ø> (ø)
src/bilqr.jl 100.00% <ø> (ø)
src/cg.jl 100.00% <ø> (ø)
src/cg_lanczos.jl 100.00% <ø> (ø)
src/cgls.jl 100.00% <ø> (ø)
src/cgne.jl 100.00% <ø> (ø)
src/cgs.jl 100.00% <ø> (ø)
src/cr.jl 57.23% <ø> (-0.27%) ⬇️
src/craig.jl 96.72% <ø> (-0.03%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6b051...badf31a. Read the comment docs.

@amontoison
Copy link
Member Author

amontoison commented Oct 19, 2020

We don't have any news from JuliaDocs/DocStringExtensions.jl for our problem. Should we add signatures in the docstring by hand for the moment? It will be better than nothing.

@dpo
Copy link
Member

dpo commented Oct 19, 2020

Sure. DocstringExtensions is a bit disappointing... :-(

@amontoison
Copy link
Member Author

amontoison commented Oct 20, 2020

It's not fun to do, but It should help a lot the users of Krylov.jl.

@dpo
Copy link
Member

dpo commented Oct 20, 2020

Indeed! Thank you!

@dpo dpo merged commit 47ff50f into JuliaSmoothOptimizers:master Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants