Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Tests are failing #83

Closed
amontoison opened this issue Sep 23, 2023 · 10 comments · Fixed by #86
Closed

[CI] Tests are failing #83

amontoison opened this issue Sep 23, 2023 · 10 comments · Fixed by #86

Comments

@amontoison
Copy link
Member

I suspect that the culprit is the new release of METIS.jl.

@dpo
Copy link
Member

dpo commented Oct 18, 2023

The error occurs in a test that doesn’t use Metis I think:
https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/blob/main/test/runtests.jl#L173

Here is the error:

test in-place version: Test Failed at /home/runner/work/LimitedLDLFactorizations.jl/LimitedLDLFactorizations.jl/test/runtests.jl:173
  Expression: allocs == 0
   Evaluated: 48 == 0

https://github.com/JuliaSmoothOptimizers/LimitedLDLFactorizations.jl/actions/runs/6542419224/job/17765412771#step:6:138

@amontoison
Copy link
Member Author

We should try wrap these unit tests in functions. I remember that extra bits where allocated in the tests of Krylov.jl because of the scope of the variables.

@geoffroyleconte May I ask you to have a look?

@dpo
Copy link
Member

dpo commented Oct 18, 2023

It’s odd because the same code in a function run with —track-allocations reports exactly zero allocations. So it has to do with the tests themselves.

@amontoison
Copy link
Member Author

Ok, so you almost confirmed that the culprit is the global scope.

@dpo
Copy link
Member

dpo commented Oct 18, 2023

In Krylov.jl, the tests are not in functions though … 🤔

@amontoison
Copy link
Member Author

If I update the Project.toml such that AMD = "=0.5.0", I don't have the error anymore.

@amontoison
Copy link
Member Author

In Krylov.jl, the tests are not in functions though … 🤔

I mixed things up... It was for older versions of Julia that I wrapped the Krylov tests in functions.

@dpo
Copy link
Member

dpo commented Oct 18, 2023

Please submit a PR.

@amontoison
Copy link
Member Author

We need to solve the problem first, I don't know why the version 0.5.1 of AMD.jl introduced some allocations.

@amontoison
Copy link
Member Author

I found the culprit.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants