Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor updates to L-SR1 operator #145

Merged
merged 3 commits into from
Apr 1, 2020
Merged

minor updates to L-SR1 operator #145

merged 3 commits into from
Apr 1, 2020

Conversation

dpo
Copy link
Member

@dpo dpo commented Mar 31, 2020

I made mem a keyword arguments. The rest is all nitpicks.

@abelsiqueira
Copy link
Member

The tests need to fixed as well.

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #145 into master will increase coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage   96.32%   96.33%   +0.01%     
==========================================
  Files          14       14              
  Lines         625      627       +2     
==========================================
+ Hits          602      604       +2     
  Misses         23       23
Impacted Files Coverage Δ
src/lbfgs.jl 98% <80%> (ø) ⬆️
src/lsr1.jl 98.55% <94.73%> (+0.04%) ⬆️
src/PreallocatedLinearOperators.jl 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ae3ab...5a2245b. Read the comment docs.

@dpo dpo requested a review from abelsiqueira April 1, 2020 13:17
@abelsiqueira abelsiqueira merged commit 174c648 into master Apr 1, 2020
@abelsiqueira abelsiqueira deleted the small-updates-lsr1 branch April 1, 2020 23:52
@abelsiqueira
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants