Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LinearOperators 2.2 to compat #38

Merged
merged 2 commits into from Dec 22, 2021

Conversation

geoffroyleconte
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #38 (cd97d0f) into main (8363d84) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files           6        6           
  Lines         623      623           
=======================================
  Hits          609      609           
  Misses         14       14           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8363d84...cd97d0f. Read the comment docs.

@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@geoffroyleconte
Copy link
Member Author

I think that the breakage failures are because of compatibility issues that can be fixed if the NLPModels and NLPModelsModifiers dependancies of the other packages are updated.
However I do not know why the FreeBSD tests fail, does anybody know?

@tmigot
Copy link
Member

tmigot commented Dec 21, 2021

I think that the breakage failures are because of compatibility issues that can be fixed if the NLPModels and NLPModelsModifiers dependancies of the other packages are updated. However I do not know why the FreeBSD tests fail, does anybody know?

Just to confirm that the breaking packages are not fully updated to NLPModels 0.18 yet ;).
For the other issue, I don't know...

@tmigot
Copy link
Member

tmigot commented Dec 21, 2021

This error has been here for a while actually, since version 0.4.0 (or since the change master to main), and we have been ignoring it...

Project.toml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

Package name latest stable
ADNLPModels.jl
AmplNLReader.jl
CUTEst.jl
CaNNOLeS.jl
DCI.jl
JSOSolvers.jl
LLSModels.jl
NLPModelsIpopt.jl
NLPModelsJuMP.jl
NLPModelsTest.jl
Percival.jl
QuadraticModels.jl
SolverBenchmark.jl
SolverTools.jl

@dpo
Copy link
Member

dpo commented Dec 21, 2021

@dpo
Copy link
Member

dpo commented Dec 22, 2021

FreeBSD fixed! 🎉

@geoffroyleconte
Copy link
Member Author

Nice thanks! Do I need to re-run all tests?

@dpo
Copy link
Member

dpo commented Dec 22, 2021

No, this should be good to go

@tmigot tmigot merged commit 42929c1 into JuliaSmoothOptimizers:main Dec 22, 2021
@geoffroyleconte geoffroyleconte deleted the compat-linop branch December 23, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants