Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a column solver name in the logs of bmark_solvers #154

Closed
tmigot opened this issue Mar 6, 2024 · 2 comments · Fixed by #155
Closed

Add a column solver name in the logs of bmark_solvers #154

tmigot opened this issue Mar 6, 2024 · 2 comments · Fixed by #155
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tmigot
Copy link
Member

tmigot commented Mar 6, 2024

This was initiated in #150 and discussed in #153 .

The line that prints after each problem:

@info log_header(colstats, types[col_idx], hdr_override = info_hdr_override)

MWE

using NLPModelsTest
using DataFrames, SolverCore, SolverBenchmark

function newton(nlp)
stats = GenericExecutionStats(nlp)
set_solver_specific!(stats, Symbol("isConvex"), :is_convex)
return stats
end
lbfgs(nlp) = newton(nlp)

solvers = Dict(
    :Newton => newton,
    :LBFGS => lbfgs
)
problems = [NLPModelsTest.BROWNDEN()]
stats = bmark_solvers(solvers, problems)
@tmigot tmigot added enhancement New feature or request good first issue Good for newcomers labels Mar 6, 2024
@Jay-sanjay
Copy link

HI @tmigot I was trying to tackle this issue and trying something like this

          info_hdr_override = merge(info_hdr_override, Dict(:solver => s.solver_name))
          @info log_header(colstats, types[col_idx], hdr_override = info_hdr_override)

Is it the way, or what other things I need to handle ?

@tmigot
Copy link
Member Author

tmigot commented Mar 11, 2024

Hi @Jay-sanjay ! Thanks for the suggestion, actualy, there is an ongoing PR to fix this but the link wasn't done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants