Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log solver name before each set #153

Merged
merged 1 commit into from
Mar 6, 2024
Merged

log solver name before each set #153

merged 1 commit into from
Mar 6, 2024

Conversation

dpo
Copy link
Member

@dpo dpo commented Mar 2, 2024

closes #150

@dpo dpo requested a review from tmigot March 2, 2024 22:23
@dpo dpo changed the title log solver name before each sert log solver name before each set Mar 2, 2024
Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (bbec059) to head (a51da6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #153   +/-   ##
=======================================
  Coverage   77.84%   77.84%           
=======================================
  Files          13       13           
  Lines         325      325           
=======================================
  Hits          253      253           
  Misses         72       72           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks!

What do you think about the suggestions made in the issue? (Adding the solver name in a column -- maybe instead of having the info)

@dpo
Copy link
Member Author

dpo commented Mar 5, 2024

Replacing "Info" means creating a custom logger, I believe, so we would have to create one per solver. I don't think that's what we want to do. We could add a column with the solver name.

@tmigot
Copy link
Member

tmigot commented Mar 6, 2024

Okay, let's merge this one and create a new issue about adding a column then.

@tmigot tmigot merged commit c234129 into main Mar 6, 2024
16 checks passed
@tmigot tmigot deleted the log-solver-name branch March 6, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solver name displayed after Info: ?
2 participants