Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid AbstractVector in stats.solver_specific #102

Merged

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Nov 4, 2021

Connected to #101 , we do not keep AbstractVector from stats.solver_specific in the output of solver_problems (and therefore bmark_solvers)

@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #102 (f5f82ea) into main (be8d2f1) will increase coverage by 0.64%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   77.17%   77.81%   +0.64%     
==========================================
  Files          13       13              
  Lines         311      311              
==========================================
+ Hits          240      242       +2     
+ Misses         71       69       -2     
Impacted Files Coverage Δ
src/run_solver.jl 86.84% <33.33%> (+2.63%) ⬆️
src/formats.jl 76.92% <0.00%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be8d2f1...f5f82ea. Read the comment docs.

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the PR.

@abelsiqueira abelsiqueira merged commit f1be039 into JuliaSmoothOptimizers:main Nov 4, 2021
@tmigot tmigot deleted the fix-vector-specifics branch November 4, 2021 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants