Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "NLPModels" to "0.18" #109

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the NLPModels package from 0.14, 0.15, 0.16, 0.17 to 0.14, 0.15, 0.16, 0.17, 0.18.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@dpo
Copy link
Member

dpo commented Dec 18, 2021

NLPModels 0.17.2 was installed, not 0.18

@tmigot tmigot force-pushed the compathelper/new_version/2021-12-18-00-08-30-046-2968955751 branch from bf7a96e to 315753a Compare December 20, 2021 13:56
@codecov
Copy link

codecov bot commented Dec 20, 2021

Codecov Report

Merging #109 (315753a) into main (156b2c5) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   77.70%   77.27%   -0.44%     
==========================================
  Files          13       12       -1     
  Lines         314      308       -6     
==========================================
- Hits          244      238       -6     
  Misses         70       70              
Impacted Files Coverage Δ
src/latex_tables.jl 0.00% <0.00%> (-30.00%) ⬇️
src/markdown_tables.jl 0.00% <0.00%> (-25.00%) ⬇️
src/SolverBenchmark.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 156b2c5...315753a. Read the comment docs.

@tmigot tmigot merged commit 8feed07 into main Dec 21, 2021
@tmigot tmigot deleted the compathelper/new_version/2021-12-18-00-08-30-046-2968955751 branch December 21, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants