CompatHelper: bump compat for "NLPModels" to "0.18" #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
NLPModels 0.17.2 was installed, not 0.18 |
tmigot
force-pushed
the
compathelper/new_version/2021-12-18-00-08-30-046-2968955751
branch
from
bf7a96e
to
315753a
Compare
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 77.70% 77.27% -0.44%
==========================================
Files 13 12 -1
Lines 314 308 -6
==========================================
- Hits 244 238 -6
Misses 70 70
Continue to review full report at Codecov.
|
tmigot
approved these changes
Dec 20, 2021
tmigot
deleted the
compathelper/new_version/2021-12-18-00-08-30-046-2968955751
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
NLPModelspackage from0.14, 0.15, 0.16, 0.17to0.14, 0.15, 0.16, 0.17, 0.18.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.