-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix string15 supertype #134
Conversation
Codecov ReportBase: 75.16% // Head: 75.47% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
+ Coverage 75.16% 75.47% +0.31%
==========================================
Files 12 12
Lines 310 314 +4
==========================================
+ Hits 233 237 +4
Misses 77 77
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can also set manually SolverBenchmark.default_formatters[InlineString] = "%15s"
I think that would be better so we don't overload this package with types defined elsewhere. I've never heard of String15 or of InlineString.
@dpo the way I implemented it, it is not overloaded with types defined elsewhere, and no additional modules are imported. I think saving DataFrames generated by But if you still don't like it feel free to close this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see. Let's just remove the commented out code then.
Co-authored-by: Dominique <dominique.orban@gmail.com>
Thank you. |
When using
solve_problems
and saving my results to a CSV file with CSV.jl, I generate aString15 <: InlineString <: AbstractString
column for the problem names. Sincesupertype(String15) = InlineString
which is not indefault_formatters
, I made the changes in this PR so that the formatter of aString15
is"%15s"
.If you do not like this change, I can also set manually
SolverBenchmark.default_formatters[InlineString] = "%15s"
everytime and close this PR.