Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade DataFrames #145

Merged
merged 1 commit into from
Nov 21, 2023
Merged

upgrade DataFrames #145

merged 1 commit into from
Nov 21, 2023

Conversation

dpo
Copy link
Member

@dpo dpo commented Nov 18, 2023

This starts a chain reaction where PrettyTables and other packages also need to be updated. As a result, the calling sequences to output Markdown and LaTeX tables must be adjusted.

Copy link

codecov bot commented Nov 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (34e1014) 77.63% compared to head (cd83fdb) 77.84%.

Files Patch % Lines
src/latex_formats.jl 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #145      +/-   ##
==========================================
+ Coverage   77.63%   77.84%   +0.20%     
==========================================
  Files          13       13              
  Lines         322      325       +3     
==========================================
+ Hits          250      253       +3     
  Misses         72       72              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This starts a chain reaction where PrettyTables and other packages
also need to be updated. As a result, the calling sequences to
output Markdown and LaTeX tables must be adjusted.
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@dpo dpo merged commit 5097610 into main Nov 21, 2023
16 checks passed
@dpo dpo deleted the bump-df branch November 21, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants