Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to BenchmarkProfiles 0.3.4 #96

Merged

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jul 20, 2021

The last release of BenchmarkProfiles.jl added a backend in the performance_profile.jl. Following, what was already documented here, I used the PlotsBackend.

We also have to convert the data into Float64 to satisfy a constraint on the input matrix see L.129 in BenchmarkProfiles.jl.

@codecov
Copy link

codecov bot commented Jul 20, 2021

Codecov Report

Merging #96 (7f6242f) into main (e77664c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage   76.30%   76.30%           
=======================================
  Files          13       13           
  Lines         287      287           
=======================================
  Hits          219      219           
  Misses         68       68           
Impacted Files Coverage Δ
src/profiles.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77664c...7f6242f. Read the comment docs.

@abelsiqueira
Copy link
Member

Looks like there is still some issue with the docs. @tmigot, do you know what it is?

@tmigot
Copy link
Member Author

tmigot commented Jul 23, 2021

Looks like there is still some issue with the docs. @tmigot, do you know what it is?

Same problem as with BenchmarkProfiles.jl, I had to set the environment variable. There is a new error with the nightly now, but it is unrelated.

@abelsiqueira abelsiqueira merged commit 499b076 into JuliaSmoothOptimizers:main Jul 23, 2021
@abelsiqueira
Copy link
Member

Thanks. Does this need a new release?

@tmigot
Copy link
Member Author

tmigot commented Jul 23, 2021

@abelsiqueira Yes, it does for compatibility with BenchmarkProfiles.

@tmigot tmigot deleted the bump-benchmarkprofiles-034 branch July 23, 2021 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants