Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize aredpred to NLS #201

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Specialize aredpred to NLS #201

merged 1 commit into from
Jun 13, 2023

Conversation

tmigot
Copy link
Member

@tmigot tmigot commented Jun 12, 2023

Close #190

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.40 🎉

Comparison is base (13672a6) 96.85% compared to head (32ad462) 97.26%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   96.85%   97.26%   +0.40%     
==========================================
  Files           8        8              
  Lines         191      219      +28     
==========================================
+ Hits          185      213      +28     
  Misses          6        6              
Impacted Files Coverage Δ
src/trust-region/tron-trust-region.jl 100.00% <100.00%> (ø)
src/trust-region/trust-region.jl 97.56% <100.00%> (+2.32%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Package name latest stable
DCISolver.jl
JSOSolvers.jl
Percival.jl

Copy link
Member

@abelsiqueira abelsiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me.

@tmigot tmigot merged commit afa02df into main Jun 13, 2023
23 checks passed
@tmigot tmigot deleted the add-nls branch June 13, 2023 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aredpred_common allocates for NLS
2 participants