Throw ArgumentError from copy! when n<0

Julia 0.5 changed this, need to be consistent for tests to pass with any type.
JuliaStats · Jul 3, 2016 · 878038e · 878038e
1 parent 9428f16
commit 878038e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/dataarray.jl b/src/dataarray.jl
@@ -176,7 +176,11 @@ function Base.copy!(dest::DataArray, doffs::Integer, src::DataArray, soffs::Inte
     if n == 0
         return dest
     elseif n < 0
-        throw(BoundsError())
+        if VERSION >= v"0.5.0-dev+4711"
+            throw(ArgumentError("tried to copy n=$n elements, but n should be nonnegative"))
+        else
+            throw(BoundsError())
+        end
     end
     if isbits(eltype(src))
         copy!(dest.data, doffs, src.data, soffs, n)

diff --git a/test/dataarray.jl b/test/dataarray.jl
@@ -92,7 +92,11 @@ module TestDataArray
             @test_throws BoundsError copy!(dest, 1, src, idx, 1)
         end
 
-        @test_throws BoundsError copy!(dest, 1, src, 1, -1)
+        if VERSION >= v"0.5.0-dev+4711"
+            @test_throws ArgumentError copy!(dest, 1, src, 1, -1)
+        else
+            @test_throws BoundsError copy!(dest, 1, src, 1, -1)
+        end
 
         @test_throws BoundsError copy!(dest, bigsrc)