This repository has been archived by the owner on May 4, 2019. It is now read-only.
Make Each(Drop|Replace|Fail)Null iterators faster #289
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiler previously did not know that the result would never be Null.
This dramatically improves their efficiency.
Also require that the type of replacement matches eltype of iterator
for
EachReplaceNull
, which is much faster.Nulls.replace()
alreadytakes care of converting it on construction.
Optimizations need to rely on the particular fields of
DataArray
.This requires restricting them to
DataArray
, and moving codeto dataarray.jl since the type had not been defined in abstractdataarray.jl.
Rather than adding specialized iterators for
PooledDataArray
, whichis going to be deprecated, rely on the generic iterators provided
by
Nulls
, which are already faster than the current ones.Cf. JuliaData/Missings.jl#50
Before (on Julia 0.6.0):
After (on Julia 0.6.0):