This repository has been archived by the owner on May 4, 2019. It is now read-only.
Stop leaking details about the implementation of PDA's #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No more get_indices No more index_to_level No more level_to_index
|
Is anyone opposed to this? It seems like such a clear improvement to me that I'll just go ahead and merge it soon in the absence of objections. |
|
Sure. I can remember a few cases where I used a factor in R to represent categories which I considered linearly spaced (e.g. diplomas), and which in some cases I wanted to transform into an integer variable. But I think that's a corner case, and to do that you do not need access to the actual implementation (i.e. you can create your own integer values with |
johnmyleswhite
added a commit
that referenced
this pull request
Jan 7, 2014
Stop leaking details about the implementation of PDA's
|
Totally agree that there are cases in which you want a mapping from categories to integers. We can make a function that constructs such a mapping for users. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes three functions we should probably never have created:
get_indicesindex_to_levellevel_to_indexUsers should not be accessing our internal representation of PDA's as part of their normal workflow. The R documentation voices its wish that users wouldn't do this, but then concedes that it happens all the time. We should not let that happen to Julia.