Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor Out Common Distance API to Leverage eval_op, ... etc. #126

Closed
bhgomes opened this issue Apr 20, 2019 · 2 comments
Closed

Factor Out Common Distance API to Leverage eval_op, ... etc. #126

bhgomes opened this issue Apr 20, 2019 · 2 comments

Comments

@bhgomes
Copy link

bhgomes commented Apr 20, 2019

I think it would be beneficial to factor out the eval_op, eval_end, eval_reduce API so that others who want to define custom metrics (like #95) can extend the already optimized evaluate that is built off of them. Not sure how this would interact with UnionMetrics.

@dkarrasch
Copy link
Member

@bhgomes Could it be that this is resolved by #163? Depending on what you want to define, PreMetric, SemiMetric or Metric, you can subtype your custom metric to Union[Pre/Semi]Metric, overload those functions that are not covered by the generic fallbacks, and otherwise let the package do its job. See #151 (comment) for an example.

@dkarrasch
Copy link
Member

Closed by #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants