Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

turn UnionMetrics into types #163

Merged
merged 1 commit into from
Apr 10, 2020
Merged

turn UnionMetrics into types #163

merged 1 commit into from
Apr 10, 2020

Conversation

dkarrasch
Copy link
Member

As discussed in #150 (comment), this allows for dispatching on Union*Metric types, and should facilitate hooking into the eval_*** and parameters business.

@KristofferC
Copy link
Member

Makes sense to me, I wonder how breaking this is.

@dkarrasch
Copy link
Member Author

I don't think it's breaking. Previously, the UnionMetrics and evaluate(::UnionMetrics, a, b) framework were closed for external packages. So this change here is, as far as I see, a truly new feature. Maybe I should add some documentation on how to write a new UnionMetric?

@KristofferC
Copy link
Member

Could be added later

@KristofferC KristofferC merged commit 4ebcc17 into JuliaStats:master Apr 10, 2020
@dkarrasch dkarrasch deleted the union_types branch April 10, 2020 16:14
@dkarrasch dkarrasch mentioned this pull request Apr 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dkarrasch @KristofferC