Add dims argument to pairwise #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows specifying whether observations are stored as columns (dims=2) or as rows (dims=1). All functions are still written internally to perform computations over columns, computations over rows are supported by calling transpose on the matrices. Add a deprecation to require specifying explicitly dims=1 or dims=2: contrary to this package, other implementations most frequently default to dims=1, and even in Julia the cov and cor functions default to dims=1.
nalimilan
commented
Feb 9, 2019
andreasnoack
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying whether observations are stored as columns (
dims=2) or as rows (dims=1).All functions are still written internally to perform computations over columns, computations over rows are supported by calling transpose on the matrices.
Add a deprecation to require specifying explicitly
dims=1ordims=2: contrary to this package, other implementations most frequently default todims=1, and even in Julia thecovandcorfunctions default todims=1.Fixes #35.