Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

should MvNormalCanon _rand! accept AbstractVecOrMat? #534

Closed
tawheeler opened this issue Sep 12, 2016 · 0 comments · Fixed by #625
Closed

should MvNormalCanon _rand! accept AbstractVecOrMat? #534

tawheeler opened this issue Sep 12, 2016 · 0 comments · Fixed by #625

Comments

@tawheeler
Copy link

tawheeler commented Sep 12, 2016 •
edited

The current implementation of for MvNormalCanon's _rand! in v0.4 is:

_rand!(d::MvNormalCanon, x::AbstractMatrix) = add!(unwhiten_winv!(d.J, randn!(x)), d.μ)

This is causing problems with the test for ConjugatePriors.jl. Can we change it to _rand!(d::MvNormalCanon, x::AbstractVecOrMat)? I think that still works as intended, but someone who knows their stuff should verify.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow AbstractVector in _rand! for ConjugatePriors.jl mschauer/Distributions.jl
1 participant
@tawheeler