Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform zeros like syntax #1035

Closed
wants to merge 1 commit into from
Closed

Uniform zeros like syntax #1035

wants to merge 1 commit into from

Conversation

aminya
Copy link

@aminya aminya commented Dec 14, 2019

julia> Uniform(Float32,-1,1)
Uniform{Float32}(a=-1.0f0, b=1.0f0)

@codecov-io
Copy link

Codecov Report

Merging #1035 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1035      +/-   ##
==========================================
- Coverage   78.27%   78.26%   -0.02%     
==========================================
  Files         112      112              
  Lines        5345     5346       +1     
==========================================
  Hits         4184     4184              
- Misses       1161     1162       +1
Impacted Files Coverage Δ
src/univariate/continuous/uniform.jl 84% <0%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3151573...5130723. Read the comment docs.

@matbesancon
Copy link
Member

The feature is interesting. Wasn't there anything already in the package doing this?
Before merging that, could you add a bunch of tests and docstring to Uniform explaining the behaviour?

@andreasnoack
Copy link
Member

I think Uniform{Float32}(-1, 1) would be more in line with how we typically do this, e.g.

julia> Complex{Float32}(1,1)
1.0f0 + 1.0f0im

@aminya
Copy link
Author

aminya commented Dec 21, 2019

I think Uniform{Float32}(-1, 1) would be more in line with how we typically do this, e.g.

julia> Complex{Float32}(1,1)
1.0f0 + 1.0f0im

That is one of the APIs that I specified in this issue However, we need to first fix the type stability. The issue is bigger than the API

@aminya
Copy link
Author

aminya commented Dec 31, 2019

Proceeded by #1045

@aminya aminya closed this Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants