Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dof approach to proper allowrankdeficient values #265

Merged
merged 1 commit into from
Nov 18, 2018
Merged

Using dof approach to proper allowrankdeficient values #265

merged 1 commit into from
Nov 18, 2018

Conversation

Nosferican
Copy link
Contributor

This PR fixes the dof for allowrankdeficient models and also dof_residual through the use of dof.

@codecov-io
Copy link

codecov-io commented Nov 9, 2018

Codecov Report

Merging #265 into master will decrease coverage by 0.17%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #265      +/-   ##
=========================================
- Coverage   51.97%   51.8%   -0.18%     
=========================================
  Files           6       6              
  Lines         583     583              
=========================================
- Hits          303     302       -1     
- Misses        280     281       +1
Impacted Files Coverage Δ
src/lm.jl 50% <0%> (-1.14%) ⬇️
src/linpred.jl 48.31% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4966a05...db941c2. Read the comment docs.

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Nosferican
Copy link
Contributor Author

This is ready to be merged.

@andreasnoack andreasnoack merged commit 1203e76 into JuliaStats:master Nov 18, 2018
@nalimilan nalimilan mentioned this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants