Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import/export fitted #389

Merged
merged 2 commits into from Dec 11, 2020
Merged

import/export fitted #389

merged 2 commits into from Dec 11, 2020

Conversation

kleinschmidt
Copy link
Member

fitted is defined in StatsBase.jl, and a method is defined in GLM.jl, but
fitted is not imported, and it's also not exported (as far as I can tell).
This PR just imports/exports fitted and adds one test to check that the method
resolves correctly and produces the same value as predict(::LinPredModel) (as
defined).

@nalimilan nalimilan closed this Dec 11, 2020
@nalimilan nalimilan reopened this Dec 11, 2020
@codecov-io
Copy link

Codecov Report

Merging #389 (89b640c) into master (3234f5e) will decrease coverage by 0.87%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   79.56%   78.68%   -0.88%     
==========================================
  Files           7        7              
  Lines         685      685              
==========================================
- Hits          545      539       -6     
- Misses        140      146       +6     
Impacted Files Coverage Δ
src/GLM.jl 100.00% <ø> (ø)
src/glmfit.jl 74.89% <0.00%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3234f5e...89b640c. Read the comment docs.

@nalimilan nalimilan merged commit 2775380 into master Dec 11, 2020
@nalimilan nalimilan deleted the dfk/fitted branch December 11, 2020 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants