Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix QR based fitting #559

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix QR based fitting #559

wants to merge 2 commits into from

Conversation

andreasnoack
Copy link
Member

@andreasnoack andreasnoack commented May 7, 2024

Avoid erroring out for low rank design matrices when dropcollinear=false.
Avoid unnecessary triangular solves. Avoid indexing in the Q.
Avoid slicing R matrix in a way that triggers a minimum norm solution.
Remove unnecessary temporaries.

#558

I removed the white space so please review with https://github.com/JuliaStats/GLM.jl/pull/559/files?w=1

Avoid erroring out for low rank design matrices when dropcollinear=false.
Avoid unnecessary triangular solves. Avoid indexing in the Q.
Avoid slicing R matrix in a way that triggers a minimum norm solution.
Remove unnecessary temporaries.
Copy link

codecov bot commented May 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (e2f6c98) to head (35c3e94).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
- Coverage   89.86%   89.71%   -0.16%     
==========================================
  Files           8        8              
  Lines        1125     1108      -17     
==========================================
- Hits         1011      994      -17     
  Misses        114      114              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andreasnoack andreasnoack requested review from devmotion and removed request for mousum-github May 17, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant