Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes fit(LassoPath,@formula,df) interface and adds tests for it #30

Merged
merged 8 commits into from
May 22, 2019

Conversation

AsafManela
Copy link
Collaborator

@AsafManela AsafManela commented May 6, 2019

Previously the StatsModels.DataFramesRegressionModel was incompatible with Lasso.jl's using a keyword argument for the intercept, so fit(LassoPath, formula(Y~X), df) did not work properly.

fit(LassoModel, @formula(Y~X), df; select=MinAIC()) did not work at all.

This PR fixes that issue and adds tests for both.

@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 162

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 88.618%

Totals Coverage Status
Change from base Build 161: 0.2%
Covered Lines: 545
Relevant Lines: 615

💛 - Coveralls

@coveralls
Copy link

coveralls commented May 6, 2019

Pull Request Test Coverage Report for Build 166

  • 11 of 12 (91.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 88.548%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/segselect.jl 10 11 90.91%
Totals Coverage Status
Change from base Build 161: 0.1%
Covered Lines: 549
Relevant Lines: 620

💛 - Coveralls

@AsafManela AsafManela merged commit 4012d4f into JuliaStats:master May 22, 2019
@AsafManela AsafManela deleted the am/statsmodelsintegration branch June 22, 2019 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants