Correct show and predict after selectmodel and remove side effects #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d predit example in docs
AsafManela
changed the title
Pull Request Test Coverage Report for Build 180
💛 - Coveralls |
|
Awesome! Has a release been tagged? |
|
yes. v0.5.1 should work
- Asaf
…On Wed, Jan 1, 2020, 5:43 PM Lyndon White ***@***.***> wrote:
Awesome! Has a release been tagged?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#37?email_source=notifications&email_token=ADJM2OTQJAQ6WKTGCF3TOXLQ3UTC7A5CNFSM4JYTYYHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5O6TQ#issuecomment-570093390>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADJM2OSFQKDP773XGUBEYMTQ3UTC7ANCNFSM4JYTYYHA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
show(::RegularizedModel)to avoid issues with reporting standard errors, which are not well defined for Lasso. Now we only show the coefficient point estimates. closes "matrix not square" error #36selectmodel. closes The first time selectmodel is called it returns an invalid model, the second time fixes it #35predictafter model selection