Grouping for 2.x #353
Merged
Grouping for 2.x #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add Grouping contrasts * export and add a getproperty patch to work around statsmodels * warn users to use Grouping when OOM during schema call * Update src/grouping.jl Co-authored-by: Phillip Alday <phillip.alday@mpi.nl> (cherry picked from commit 2f9d423)
|
@kleinschmidt Since this is a backport of your contribution, care to give a cursory review? |
Codecov Report
@@ Coverage Diff @@
## v2.x #353 +/- ##
==========================================
- Coverage 92.26% 91.95% -0.32%
==========================================
Files 18 19 +1
Lines 1332 1342 +10
==========================================
+ Hits 1229 1234 +5
- Misses 103 108 +5
Continue to review full report at Codecov.
|
kleinschmidt
approved these changes
Aug 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another easy backport.