Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more tinkering on 638 #654

Merged
merged 2 commits into from Oct 20, 2022
Merged

more tinkering on 638 #654

merged 2 commits into from Oct 20, 2022

Conversation

palday
Copy link
Member

@palday palday commented Oct 18, 2022

I made it return the same result as lme4.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 94.23% // Head: 93.97% // Decreases project coverage by -0.26% ⚠️

Coverage data is based on head (b857885) compared to base (0ffbaa5).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head b857885 differs from pull request most recent head 4437847. Consider uploading reports for the commit 4437847 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   94.23%   93.97%   -0.27%     
==========================================
  Files          29       29              
  Lines        2795     2622     -173     
==========================================
- Hits         2634     2464     -170     
+ Misses        161      158       -3     
Impacted Files Coverage Δ
src/linearmixedmodel.jl 97.97% <100.00%> (-0.14%) ⬇️
src/remat.jl 96.71% <100.00%> (-0.28%) ⬇️
src/linalg.jl 98.03% <0.00%> (-1.97%) ⬇️
src/arraytypes.jl 93.61% <0.00%> (-0.51%) ⬇️
src/serialization.jl 93.33% <0.00%> (-0.42%) ⬇️
src/generalizedlinearmixedmodel.jl 90.15% <0.00%> (-0.37%) ⬇️
src/Xymat.jl 90.00% <0.00%> (-0.25%) ⬇️
src/linalg/rankUpdate.jl 97.97% <0.00%> (-0.22%) ⬇️
src/predict.jl 98.11% <0.00%> (-0.20%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@palday palday marked this pull request as ready for review October 20, 2022 04:32
@palday palday requested a review from dmbates October 20, 2022 04:33
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up those redundant .data extractors in src/remat.jl.

@palday palday merged commit 4abda3e into main Oct 20, 2022
@palday palday deleted the pa/scaling branch October 20, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants