Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MDS code and docs (for #109) #168

Merged
merged 3 commits into from
Jan 17, 2022

Conversation

wildart
Copy link
Collaborator

@wildart wildart commented Jan 14, 2022

Added new docs and functions to satisfy new API (#109).

@wildart wildart mentioned this pull request Jan 14, 2022
@kescobo
Copy link
Contributor

kescobo commented Jan 14, 2022

👍 Great to see this moving! Probably worth update GHA to test on 1.6 (the new LTS), 1.7, and nightly, no?

I'd be happy to make a separate PR to implement that if it would be helpful

@wildart
Copy link
Collaborator Author

wildart commented Jan 14, 2022

I don't want to get rid of 1.1. The test are quite stable for that version, it serves as reference for other test configs.
I think we need to use StableRNGs for generating test random data for newer julia versions. That should be a priority update.

@kescobo
Copy link
Contributor

kescobo commented Jan 14, 2022

Would you like me to help with that?

@wildart wildart merged commit 1a871a3 into JuliaStats:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants