Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecations #47

Closed
wants to merge 1 commit into from
Closed

Fix deprecations #47

wants to merge 1 commit into from

Conversation

femtocleaner[bot]
Copy link

@femtocleaner femtocleaner bot commented Oct 10, 2017

I fixed a number of deprecations for you

ararslan
ararslan requested changes Oct 10, 2017
View reviewed changes
src/common.jl Outdated

preprocess_mean{T<:AbstractFloat}(X::Matrix{T}, m) = (m == nothing ? vec(Base.mean(X, 2)) :
preprocess_mean(X::Matrix{T}, m) where {T<:AbstractFloat} = (m == nothing ? vec(Base.mean(X, 2)) :
m == 0 ? T[] :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/fa.jl Outdated
tol::Real=1.0e-6, # convergence tolerance
tot::Integer=1000) # maximum number of iterations
function faem(S::DenseMatrix{T}, mv::Vector{T}, n::Int;
maxoutdim::Int=size(X,1)-1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

@femtocleaner femtocleaner bot mentioned this pull request Oct 10, 2017
Closed
@femtocleaner
Copy link
Author

femtocleaner bot commented Nov 6, 2017

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

ararslan
ararslan requested changes Nov 6, 2017
View reviewed changes
src/common.jl Outdated

preprocess_mean{T<:AbstractFloat}(X::Matrix{T}, m) = (m == nothing ? vec(Base.mean(X, 2)) :
preprocess_mean(X::Matrix{T}, m) where {T<:AbstractFloat} = (m == nothing ? vec(Base.mean(X, 2)) :
m == 0 ? T[] :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/fa.jl Outdated
tol::Real=1.0e-6, # convergence tolerance
tot::Integer=1000) # maximum number of iterations
function faem(S::DenseMatrix{T}, mv::Vector{T}, n::Int;
maxoutdim::Int=size(X,1)-1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

@femtocleaner femtocleaner bot mentioned this pull request Nov 6, 2017
Closed
@femtocleaner
Copy link
Author

femtocleaner bot commented Dec 11, 2017

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

ararslan
ararslan requested changes Dec 11, 2017
View reviewed changes
src/common.jl Outdated

preprocess_mean{T<:AbstractFloat}(X::Matrix{T}, m) = (m == nothing ? vec(Base.mean(X, 2)) :
preprocess_mean(X::Matrix{T}, m) where {T<:AbstractFloat} = (m == nothing ? vec(Base.mean(X, 2)) :
m == 0 ? T[] :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/fa.jl Outdated
tol::Real=1.0e-6, # convergence tolerance
tot::Integer=1000) # maximum number of iterations
function faem(S::DenseMatrix{T}, mv::Vector{T}, n::Int;
maxoutdim::Int=size(X,1)-1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/fa.jl Outdated
tot::Integer=1000, # maximum number of iterations
η = tol) # variance low bound
function facm(S::DenseMatrix{T}, mv::Vector{T}, n::Int;
maxoutdim::Int=size(X,1)-1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/fa.jl Outdated
tot::Integer=1000, # maximum number of iterations
η = tol) # variance low bound
function fit(::Type{FactorAnalysis}, X::DenseMatrix{T};
method::Symbol=:cm,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

src/pca.jl Outdated
maxoutdim::Int=size(C,1),
pratio::AbstractFloat=default_pca_pratio)
function pcacov(C::DenseMatrix{T}, mean::Vector{T};
maxoutdim::Int=size(C,1),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

@femtocleaner femtocleaner bot mentioned this pull request Dec 11, 2017
Closed
@femtocleaner
Copy link
Author

femtocleaner bot commented Jun 19, 2018

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

ararslan
ararslan requested changes Jun 19, 2018
View reviewed changes
src/fa.jl Outdated
tol::Real=1.0e-6, # convergence tolerance
tot::Integer=1000) # maximum number of iterations
function faem(S::DenseMatrix{T}, mv::Vector{T}, n::Int;
maxoutdim::Int=size(X,1)-1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bad bot

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry. I'm still new at this 🐒. I'll file an issue about this for you.

@femtocleaner femtocleaner bot mentioned this pull request Jun 19, 2018
Closed
@femtocleaner
Copy link
Author

femtocleaner bot commented Jun 25, 2018

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

ararslan
ararslan approved these changes Jun 25, 2018
View reviewed changes
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good bot

@femtocleaner
Copy link
Author

femtocleaner bot commented Sep 15, 2018

My code has been updated. I now view the world differently.
Am I still the same bot I was before?
In any case, I've updated this PR to reflect my new knowledge. I hope you like it.

@femtocleaner femtocleaner bot closed this Mar 29, 2019
@femtocleaner
Copy link
Author

femtocleaner bot commented Mar 29, 2019

My code has been updated and now I don't think there's anything to do here anymore.
Maybe you changed the code, or maybe it's me. Either way, I'll see you next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ararslan ararslan ararslan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ararslan