Added draft implementation of factor analysis #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft implementation of factor analysis based on the algorithm described on Bayesian Reasoning and Machine Learning (David Barber) and the scikit-learn implementation. I still did not optimize it for performance so it may have some issues (e.g., allocating memory for matrices inside the loop). I also did not write any tests but I am planning to compare it to the scikit-learn implementation on the same dataset.
Is there interest in adding it to this package if I manage to improve the implementation and write tests and documentation? Any suggestions to improve the implementation or coding style would be appreciated.