Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #28: Check the elements of X #40

Merged
merged 2 commits into from Nov 7, 2020
Merged

Fix #28: Check the elements of X #40

merged 2 commits into from Nov 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 2, 2020

I fixed #28 by adding the error handling to check the elements of X.

@ghost
Copy link
Author

ghost commented Nov 7, 2020

@andreasnoack Thank you for correcting the code appropriately.

@andreasnoack andreasnoack merged commit d2460ca into JuliaStats:master Nov 7, 2020
@ghost ghost deleted the fix-iss28 branch November 7, 2020 21:44
@mileslucas
Copy link

just an FYI this resulted in breaking changes downstream in my package. I didn't notice it until my CI started failing on a PR for a docs update, since the version was bumped to 0.4.2 instead of 0.5.

@andreasnoack
Copy link
Member

While it could also be this PR that has caused the breakage, my guess is that it is #38 that caused it. I added [Breaking] to the title of that PR to indicate that it was breaking but I should also have mentioned it in a comment. @ararslan I might be a good area to make a 0.4.3 release prior to the breaking change and then a new 0.5 release.

@ararslan
Copy link
Member

So register a 0.5.0 off of master and a 0.4.3 based on the commit prior to that PR?

@ararslan
Copy link
Member

I'm yanking 0.4.3 from the registry (JuliaRegistries/General#24448) and will reregister current master as 0.5.0.

@ghost
Copy link
Author

ghost commented Nov 11, 2020

Thank you!! I really appreciate your help in resolving the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

weird MethodError
3 participants