Widen (inv)quad signature to allow any AbstractVector

src/pdiagmat.jl

@@ -81,8 +81,8 @@ unwhiten!(r::StridedMatrix, a::PDiagMat, x::StridedMatrix) =
 
 ### quadratic forms
 
-quad(a::PDiagMat, x::Vector) = wsumsq(a.diag, x)
-invquad(a::PDiagMat, x::Vector) = wsumsq(a.inv_diag, x)
+quad(a::PDiagMat, x::AbstractVector) = wsumsq(a.diag, x)
+invquad(a::PDiagMat, x::AbstractVector) = wsumsq(a.inv_diag, x)
 
 quad!(r::AbstractArray, a::PDiagMat, x::Matrix) = At_mul_B!(r, @compat(abs2.(x)), a.diag)
 invquad!(r::AbstractArray, a::PDiagMat, x::Matrix) = At_mul_B!(r, @compat(abs2.(x)), a.inv_diag)

src/pdmat.jl

@@ -65,8 +65,8 @@ end
 
 ### quadratic forms
 
-quad(a::PDMat, x::StridedVector) = dot(x, a * x)
-invquad(a::PDMat, x::StridedVector) = dot(x, a \ x)
+quad(a::PDMat, x::AbstractVector) = dot(x, a * x)
+invquad(a::PDMat, x::AbstractVector) = dot(x, a \ x)
 
 quad!(r::AbstractArray, a::PDMat, x::StridedMatrix) = colwise_dot!(r, x, a.mat * x)
 invquad!(r::AbstractArray, a::PDMat, x::StridedMatrix) = colwise_dot!(r, x, a.mat \ x)

src/pdsparsemat.jl

@@ -62,8 +62,8 @@ end
 
 ### quadratic forms
 
-quad(a::PDSparseMat, x::StridedVector) = dot(x, a * x)
-invquad(a::PDSparseMat, x::StridedVector) = dot(x, a \ x)
+quad(a::PDSparseMat, x::AbstractVector) = dot(x, a * x)
+invquad(a::PDSparseMat, x::AbstractVector) = dot(x, a \ x)
 
 function quad!(r::AbstractArray, a::PDSparseMat, x::StridedMatrix)
     for i in 1:size(x, 2)

src/scalmat.jl

@@ -68,8 +68,8 @@ end
 
 ### quadratic forms
 
-quad(a::ScalMat, x::Vector) = sum(abs2, x) * a.value
-invquad(a::ScalMat, x::Vector) = sum(abs2, x) * a.inv_value
+quad(a::ScalMat, x::AbstractVector) = sum(abs2, x) * a.value
+invquad(a::ScalMat, x::AbstractVector) = sum(abs2, x) * a.inv_value
 
 quad!(r::AbstractArray, a::ScalMat, x::Matrix) = colwise_sumsq!(r, x, a.value)
 invquad!(r::AbstractArray, a::ScalMat, x::Matrix) = colwise_sumsq!(r, x, a.inv_value)

src/testutils.jl

@@ -5,6 +5,7 @@
 #
 
 import Base.Test: @test
+using Compat: view
 
 ## driver function
 function test_pdmat(C::AbstractPDMat, Cmat::Matrix;
@@ -182,6 +183,7 @@ function pdtest_quad(C::AbstractPDMat, Cmat::Matrix, Imat::Matrix, X::Matrix, ve
         xi = vec(X[:,i])
         r_quad[i] = dot(xi, Cmat * xi)
         @test quad(C, xi) ≈ r_quad[i]
+        @test quad(C, view(X,:,i)) ≈ r_quad[i]
     end
     @test quad(C, X) ≈ r_quad
 
@@ -191,6 +193,7 @@ function pdtest_quad(C::AbstractPDMat, Cmat::Matrix, Imat::Matrix, X::Matrix, ve
         xi = vec(X[:,i])
         r_invquad[i] = dot(xi, Imat * xi)
         @test invquad(C, xi) ≈ r_invquad[i]
+        @test invquad(C, view(X,:,i)) ≈ r_invquad[i]
     end
     @test invquad(C, X) ≈ r_invquad
 end