-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #133 #134
Fix #133 #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment. Except for that, this should be fine.
Co-authored-by: Andreas Noack <andreas@noack.dk>
Thanks! Can you approve running the workflow? |
Sure. It's the first time I've seen that one. |
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
==========================================
- Coverage 88.51% 88.31% -0.20%
==========================================
Files 9 8 -1
Lines 357 351 -6
==========================================
- Hits 316 310 -6
Misses 41 41
Continue to review full report at Codecov.
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This PR implements the fix described in #133.