Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #133 #134

Merged
merged 6 commits into from
Jun 11, 2021
Merged

Fix #133 #134

merged 6 commits into from
Jun 11, 2021

Conversation

sethaxen
Copy link
Contributor

This PR implements the fix described in #133.

Copy link
Member

@andreasnoack andreasnoack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment. Except for that, this should be fine.

src/chol.jl Outdated Show resolved Hide resolved
src/chol.jl Outdated Show resolved Hide resolved
sethaxen and others added 2 commits June 11, 2021 12:12
Co-authored-by: Andreas Noack <andreas@noack.dk>
@sethaxen
Copy link
Contributor Author

Thanks! Can you approve running the workflow?

@andreasnoack
Copy link
Member

Can you approve running the workflow?

Sure. It's the first time I've seen that one.

@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2021

Codecov Report

Merging #134 (d81e3ce) into master (84bdd88) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   88.51%   88.31%   -0.20%     
==========================================
  Files           9        8       -1     
  Lines         357      351       -6     
==========================================
- Hits          316      310       -6     
  Misses         41       41              
Impacted Files Coverage Δ
src/chol.jl 100.00% <100.00%> (ø)
src/pdmat.jl 96.07% <100.00%> (-0.42%) ⬇️
src/utils.jl 93.75% <0.00%> (-0.13%) ⬇️
src/PDMats.jl

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84bdd88...d81e3ce. Read the comment docs.

@andreasnoack andreasnoack merged commit 213c37a into JuliaStats:master Jun 11, 2021
@JuliaRegistrator
Copy link

Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue.

@JuliaStats JuliaStats deleted a comment from JuliaRegistrator Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants