Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently for
det(::AbstractPDMat)
the generic fallback in LinearAlgebra is used (https://github.com/JuliaLang/julia/blob/d4acead9130f97f0135bee604d94e1f67dabc70f/stdlib/LinearAlgebra/src/generic.jl#L1598-L1604) which performs an LU decomposition. This PR adds more efficient definitions for PDMat, PDSparseMat, ScalMat and PDiagMat.