Loosen type restrictions #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also fixing some extraneous type parameters that aren't needed
- utils now accept looser than diagonal typing - generics make sure to allocate storage big enough to hold result of mixed argument types
|
I'm leaving this up for a bit for others to take a look and comment before I merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractFloatinstead ofReal.utils.jlonly accepted diagonal dispatch (i.e., all eltypes had to match). This has been relaxed.generics.jlnow allocate storage for inplace methods with element type that is the promotion of the element types of arguments.Closes #44.