Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SuiteSparse and Arpack packages #78

Merged
merged 2 commits into from
Jun 25, 2018
Merged

Use SuiteSparse and Arpack packages #78

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd32bc6
Use SuiteSparse and Arpack packages
dmbates Jun 25, 2018
ee961ce
As per @araslan
dmbates Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions REQUIRE
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,4 @@
julia 0.7.0-DEV.5190 # for cholesky function
Compat 0.61.0
SuiteSparse
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So currently we're in a funny situation where SuiteSparse is a registered package, yet we don't want to use that, we want to use SuiteSparse from the stdlib. So using SuiteSparse is good, but it should be removed from REQUIRE.

Arpack
2 changes: 1 addition & 1 deletion src/PDMats.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ __precompile__()
module PDMats

using Compat
using IterativeEigensolvers, LinearAlgebra, SparseArrays, SuiteSparse
using LinearAlgebra, SparseArrays, SuiteSparse

import Base: +, *, \, /, ==, convert, inv, Matrix

Expand Down
1 change: 1 addition & 0 deletions src/pdsparsemat.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using Arpack
# Sparse positive definite matrix together with a Cholesky factorization object
struct PDSparseMat{T<:Real,S<:AbstractSparseMatrix} <: AbstractPDMat{T}
dim::Int
Expand Down
2 changes: 1 addition & 1 deletion test/pdmtypes.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# test pd matrix types
using LinearAlgebra, PDMats, SparseArrays
using LinearAlgebra, PDMats, SparseArrays, SuiteSparse
using Test

call_test_pdmat(p::AbstractPDMat,m::Matrix) = test_pdmat(p,m,cmat_eq=true,verbose=1)
Expand Down