-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch from GZip to CodecZlib #31
Conversation
|
I'm not sure I understand the comment that requiring Julia v0.6 will have to wait on DataFrames v0.11. Can you elaborate? Also, if checking the stream to determine the compression type will be required, it would be worthwhile allowing for other compression types. An |
There's PR #28 that both drops Julia v0.5 compatibility and updates to DataFrames v0.11. So we can merge this PR as soon as #28 lands.
Yes, that would be nice. So far I just implemented the "native" R compression formats: uncompressed (default for ASCII) and gzip (default for binary). |
Thanks for the reply. I'm not sure if I was clear that the R |
Something new to learn today, never read past |
DataFrames currently works just fine on 0.6. |
CodecZlib.jl will eventually completely replace GZip.jl.
It also offers more complete
IO
interface implementation, e.g.GzipCompressorStream
could be used byCSV.jl
to read gzipped tables.So by switching to CodecZlib we avoid having two different packages providing gzip support in different contexts.
See JuliaIO/CodecZlib.jl#7 for more details.
Gzip.jl checks whether the input stream is actually compressed, and silently switches to no-op wrapper if it's not.
CodecZlib throws an exception for uncompressed streams, so we have to check for it before.