Fix quantile with Date and DateTime
#153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before #145 `Date` and `DateTime` were supported with `quantile` as long as the cut point falls between two equal values. Restore this behavior as some code may rely on this given that it is the most common situation with large datasets.
bkamins
reviewed
Oct 2, 2023
bkamins
approved these changes
Oct 2, 2023
|
Thanks, I'm going to merge this keeping the CI on Julia 1.x given that the fix has been backported to Julia 1.10 and will normally be on 1.9.4 too. |
vtjnash
added a commit
to vtjnash/Statistics.jl
that referenced
this pull request
Nov 3, 2023
Support was removed in JuliaStats#153, though that PR failed to set the correct compat bounds
nalimilan
added a commit
that referenced
this pull request
Nov 5, 2023
nalimilan
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport JuliaStats/Statistics.jl#153.
nalimilan
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport JuliaStats/Statistics.jl#153.
nalimilan
added a commit
to JuliaLang/julia
that referenced
this pull request
Nov 5, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport JuliaStats/Statistics.jl#153.
nalimilan
pushed a commit
that referenced
this pull request
Nov 5, 2023
Support was removed in #153, though that PR failed to set the correct compat bounds
KristofferC
pushed a commit
to JuliaLang/julia
that referenced
this pull request
Nov 9, 2023
This bumps Statistics to the latest commit of the release-1.10 branch in order to backport JuliaStats/Statistics.jl#153. See JuliaData/DataFrames.jl#3383. Cc: @bkamins @George9000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before #145
DateandDateTimewere supported withquantileas long as the cut point falls between two equal values. Restore this behavior as some code may rely on this given that it is the most common situation with large datasets.(Failures on Julia 1.x are expected as the fix that allows dropping
floatis only available on master. But we probably don't care as Statistics can only be upgraded on Julia 1.11 and later.)