Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.32.1 introduces a breaking change #556

Closed
gdkrmr opened this issue Feb 21, 2020 · 4 comments
Closed

0.32.1 introduces a breaking change #556

gdkrmr opened this issue Feb 21, 2020 · 4 comments

Comments

@gdkrmr
Copy link

gdkrmr commented Feb 21, 2020

The constructor for ZScoreTransform changed between v0.32.0 and v0.32.1 and now requires an extra argument.

@Nosferican
Copy link
Contributor

Could we add a deprecation method and release a 0.32.2 to fix this?

@tbeason
Copy link

tbeason commented Feb 26, 2020

I think my issue is related to this so I'll piggyback here.

x = randn(100)
standardize(ZScoreTransform,x)

fails on v0.32.1.

As a larger and only semi-related point, can we please just make ZScoreTransform be the default? I don't see why it isn't.

@kleinschmidt
Copy link
Member

Thanks for reporting, and sorry for releasing a breaking change in a patch release. @Nosferican, AFAICT there ARE deprecation warnings in the fit(ZScoreTransform, ...) which is how most users interact with it. We could also introduce a deprecation in the constructor itself.

It also looks like the changes introduced in #490 use dims=nothing as a default but don't provide a constructor for that value, which is the source of @tbeason error.

Using z score as the default is unrelated, please open another issue to discuss that if there isn't one already.

@kleinschmidt
Copy link
Member

This should be fixed once 0.32.2 is registered: JuliaRegistries/General#10500

@tbeason, I was surprised to find that before #490, standardize and friends didn't work with a vector. It now at least provides a more explicit error message (you have to specify dims=1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants