Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to changes in Base's cov and cor #141

Merged
merged 1 commit into from
Oct 11, 2015
Merged

Update to changes in Base's cov and cor #141

merged 1 commit into from
Oct 11, 2015

Conversation

andreasnoack
Copy link
Member

These changes are necessary after JuliaLang/julia#13465 where the keyword arguments for mean and vardim were removed. Notice that the tests there won't pass before JuliaLang/julia#13505 has been merged. I got some of the deprecation definitions wrong in the first attempt.

andreasnoack added a commit that referenced this pull request Oct 11, 2015
Update to changes in Base's cov and cor
@andreasnoack andreasnoack merged commit cf94391 into master Oct 11, 2015
@andreasnoack andreasnoack deleted the anj/covcor branch October 11, 2015 00:32
@tkelman
Copy link
Contributor

tkelman commented Oct 11, 2015

The new syntax should be added to Compat, this won't be the only use case.

@andreasnoack
Copy link
Member Author

I wouldn't be so sure about that, but they are in progress anyway. I think few people uses a custom mean or MLE corrections when computing covariances. I tried to search through julia repositories on GitHub, but unfortunately the search doesn't allow = in the search expression so it's quite difficult for seach for the use of keyword arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants