-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require Julia v0.7.0-beta2 #395
Conversation
This permits massive code deletion, but means that we can only test on nightly, at least until the next 0.7 prerelease after the current beta.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but better wait until a new beta is tagged (and keep 0.7 on CI).
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 97.81% 97.97% +0.15%
==========================================
Files 18 17 -1
Lines 1418 1282 -136
==========================================
- Hits 1387 1256 -131
+ Misses 31 26 -5
Continue to review full report at Codecov.
|
Should definitely be squashed on merge. |
This permits sizable code deletion, but means that we can only test on nightly, at least until the next 0.7 prerelease after the current beta.