Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Julia v0.7.0-beta2 #395

Merged
merged 6 commits into from
Jul 16, 2018
Merged

Require Julia v0.7.0-beta2 #395

merged 6 commits into from
Jul 16, 2018

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jul 9, 2018

This permits sizable code deletion, but means that we can only test on nightly, at least until the next 0.7 prerelease after the current beta.

This permits massive code deletion, but means that we can only test on
nightly, at least until the next 0.7 prerelease after the current beta.
Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but better wait until a new beta is tagged (and keep 0.7 on CI).

@ararslan ararslan changed the title Require Julia v0.7.0-beta.85 (Statistics stdlib) Require Julia v0.7.0-beta2 Jul 16, 2018
@codecov
Copy link

codecov bot commented Jul 16, 2018

Codecov Report

Merging #395 into master will increase coverage by 0.15%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   97.81%   97.97%   +0.15%     
==========================================
  Files          18       17       -1     
  Lines        1418     1282     -136     
==========================================
- Hits         1387     1256     -131     
+ Misses         31       26       -5
Impacted Files Coverage Δ
src/cov.jl 100% <ø> (ø) ⬆️
src/rankcorr.jl 100% <100%> (ø) ⬆️
src/moments.jl 100% <100%> (+2.02%) ⬆️
src/signalcorr.jl 99.34% <0%> (-0.66%) ⬇️
src/ranking.jl 100% <0%> (ø) ⬆️
src/weights.jl 99.31% <0%> (+0.07%) ⬆️
src/scalarstats.jl 97.38% <0%> (+0.08%) ⬆️
src/hist.jl 97.2% <0%> (+0.32%) ⬆️
src/common.jl 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a4439...f3e371d. Read the comment docs.

@ararslan
Copy link
Member Author

Should definitely be squashed on merge.

@ararslan ararslan merged commit cc9ad6e into master Jul 16, 2018
@ararslan ararslan deleted the aa/bumpity-bump branch July 16, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants