Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary convert(Vector, wv) calls #548

Merged
merged 1 commit into from Feb 16, 2020
Merged

Conversation

nalimilan
Copy link
Member

AbstractWeights <: AbstractVector for a long time now. convert has to allocate a vector when UnitWeights is passed.

See #543.

`AbstractWeights <: AbstractVector` for a long time now. `convert` has to
allocate a vector when `UnitWeights` is passed.
@codecov
Copy link

codecov bot commented Jan 14, 2020

Codecov Report

Merging #548 into master will decrease coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #548     +/-   ##
========================================
- Coverage   90.39%   90.3%   -0.1%     
========================================
  Files          21      21             
  Lines        2104    2093     -11     
========================================
- Hits         1902    1890     -12     
- Misses        202     203      +1
Impacted Files Coverage Δ
src/hist.jl 90.95% <ø> (-0.05%) ⬇️
src/cov.jl 95.91% <ø> (ø) ⬆️
src/sampling.jl 91.69% <100%> (-0.03%) ⬇️
src/moments.jl 99.3% <100%> (-0.03%) ⬇️
src/counts.jl 90.07% <100%> (-0.21%) ⬇️
src/weights.jl 86.05% <0%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da42557...a80e960. Read the comment docs.

@kleinschmidt kleinschmidt self-requested a review February 16, 2020 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants