fix legacy usage of RangeGenerator #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fails on Julia-nightly tests, but this is not related to this PR AFAICT (I get a similar failure locally on Julia-nightly with StatsBase@v0.33.0). |
nalimilan
approved these changes
May 7, 2020
|
Good to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RangeGeneratoris a pre-Julia-1.0 thing, and was maintained inRandomonly to reduce breakage of packages. But the (not so) new way of doing things is nowSampler(rng, 1:n). This is supposed to select the best sampler type depending onrng.Fixes JuliaRandom/StableRNGs.jl#3.