Stop using LinearAlgebra.copy_oftype #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This undocumented function does not actually ensure that the result is mutable. Use the same approach as `Base.copymutable`, which relies only on public API.
nalimilan
commented
Jan 4, 2021
| @@ -274,7 +274,7 @@ function mad(x; center=nothing, normalize::Union{Bool, Nothing}=nothing, constan | |||
| # Knowing the eltype allows allocating a single array able to hold both original values | |||
| # and differences from the center, instead of two arrays | |||
| S = isconcretetype(T) ? promote_type(T, typeof(middle(zero(T)))) : T | |||
| x2 = x isa AbstractArray ? LinearAlgebra.copy_oftype(x, S) : collect(S, x) | |||
| x2 = x isa AbstractArray ? copyto!(similar(x, S), x) : collect(S, x) | |||
There was a problem hiding this comment.
Note that this change assumes that when S == T, copyto!(similar(x, S), x) is as fast as copy(x). Not sure whether that holds: I could add another branch to ensure that this simple case is fast.
|
I'm mainly curious about what motivated this change. Is it worth adding as a test case? |
|
That's mainly to avoid breakage if JuliaLang/julia#28956 gets merged. There's no hurry. But in general it sounds better to avoid depending on unexported and undocumented functions from the stdlib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undocumented function does not actually ensure that the result is mutable.
Use the same approach as
Base.copymutable, which relies only on public API.This avoids breakage due to JuliaLang/julia#28956 (see this log).