Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add replace and ordered keywords for sample! method (#633) #636

Merged
merged 2 commits into from
Mar 29, 2021
Merged

add replace and ordered keywords for sample! method (#633) #636

merged 2 commits into from
Mar 29, 2021

Conversation

fredcallaway
Copy link
Contributor

@fredcallaway fredcallaway commented Jan 17, 2021 •
edited

Fixes #633

@fredcallaway
Copy link
Contributor Author

The failures on nightly are in histograms, I assume not related to this patch. I can add a test case if that's desired, but it seems unnecessary given the simplicity of the change.

@nalimilan
Copy link
Member

Thanks. Can you add tests that cover the new arguments?

@fredcallaway
Copy link
Contributor Author

@nalimilan those look okay?

@nalimilan
Copy link
Member

Thanks, and sorry for the delay!

@nalimilan nalimilan merged commit 6ec4579 into JuliaStats:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sample! missing a method
2 participants
@fredcallaway @nalimilan