Reexport functions from Statistics #735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I've oftened wondered why we don't just |
|
I was tempted to do that, but as noted at #736 |
bkamins
approved these changes
Nov 22, 2021
It does not make any sense to avoid exporting functions from Statistics to which we add methods. These are documented in the manual but currently not available without typing `using Statistics`. The only method from Statistics which we do not overload is `middle`, which this commit does not reexport for now.
andreasnoack
force-pushed
the
nl/export
branch
from
79dd713
to
d563abd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not make any sense to avoid exporting functions from Statistics to which we add methods. These are documented in the manual but currently not available without typing
using Statistics.The only method from Statistics which we do not overload is
middle, which this commit does not reexport for now.Also don't reexport
stdmandvarmas they are currently not mentioned in the StatsBase manual (and should probably be deprecated, see #736).It would even make sense to also include docstrings from Statistics in the StatsBase manual so that one can get them from a single place.