Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

summarystats improvements #858

Merged
merged 9 commits into from Jun 24, 2023
Merged

Conversation

itsdebartha
Copy link
Contributor

This commit addresses issue #693

  • Add standard deviation to summarystats
  • Update documentation
  • Add tests

- Add standard deviation
- Update documentation
- Add tests
@itsdebartha
Copy link
Contributor Author

sem returns ArgumentError but expects MethodError in CI. However, in my machine, sem returns MethodError, and passes the tests.

- Changes in `IOBuffer`
@ParadaCarleton
Copy link
Contributor

The tests are failing on Julia nightly, which is fine (it usually means there's a bug in the nightly build, which is pre-alpha, rather than a bug in our code).

@itsdebartha
Copy link
Contributor Author

Yeah, seems like MethodError has changed to ArgumentError for some of the results...

Copy link
Member

@nalimilan nalimilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay.

src/scalarstats.jl Outdated Show resolved Hide resolved
test/scalarstats.jl Outdated Show resolved Hide resolved
test/scalarstats.jl Outdated Show resolved Hide resolved
src/deviation.jl Outdated Show resolved Hide resolved
itsdebartha and others added 3 commits June 19, 2023 09:20
Co-authored-by: Milan Bouchet-Valat <nalimilan@club.fr>
@itsdebartha
Copy link
Contributor Author

@nalimilan I have made the corrections. Hopefully, it is ok now...

src/scalarstats.jl Outdated Show resolved Hide resolved
@nalimilan nalimilan merged commit 82190d1 into JuliaStats:master Jun 24, 2023
16 of 18 checks passed
@itsdebartha itsdebartha deleted the SummaryStats branch June 25, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants