Fix sample with wide integer types
#873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As observed in issue 872, an unordered sample without replacement with a type 64 bits or wider (notably excluding `Int64`, at least on a 64-bit system) hits a `MethodError` in `samplepair`, which had been restricted to `Int` inputs. Relaxing this restriction and adjusting the `samplepair` implementation accordingly allows these cases to succeed.
devmotion
reviewed
Jul 1, 2023
nalimilan
reviewed
Jul 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As observed in #872, an unordered sample without replacement with a type 64 bits or wider (notably excluding
Int64, at least on a 64-bit system) hits aMethodErrorinsamplepair, which had been restricted toIntinputs. Relaxing this restriction and adjusting thesamplepairimplementation accordingly allows these cases to succeed.Fixes #872.