Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise DimensionMismatch if lengths don't match #922

Merged
merged 1 commit into from Mar 11, 2024
Merged

Raise DimensionMismatch if lengths don't match #922

merged 1 commit into from Mar 11, 2024

Conversation

jishnub
Copy link
Contributor

@jishnub jishnub commented Mar 11, 2024

raise_dimerror was not defined, so the error path used to raise an UndefVarError on master. This fixes it to actually raise a DimensionMismatch

devmotion
devmotion approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@devmotion devmotion merged commit 4c9e559 into JuliaStats:master Mar 11, 2024
17 of 18 checks passed
@devmotion devmotion mentioned this pull request Mar 11, 2024
Closed
@jishnub jishnub deleted the raisedimerr branch March 11, 2024 13:23
@devmotion devmotion mentioned this pull request Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devmotion devmotion devmotion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jishnub @devmotion